Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Parser deprecated issue #1948

Closed
vincentkoc opened this issue Oct 8, 2023 · 11 comments · Fixed by #1949
Closed

Config Parser deprecated issue #1948

vincentkoc opened this issue Oct 8, 2023 · 11 comments · Fixed by #1949

Comments

@vincentkoc
Copy link
Contributor

Traceback (most recent call last):
  File "/usr/local/bin/mackup", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/Cellar/mackup/0.8.37/libexec/lib/python3.12/site-packages/mackup/main.py", line 66, in main
    mckp = Mackup()
           ^^^^^^^^
  File "/usr/local/Cellar/mackup/0.8.37/libexec/lib/python3.12/site-packages/mackup/mackup.py", line 24, in __init__
    self._config = config.Config()
                   ^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/mackup/0.8.37/libexec/lib/python3.12/site-packages/mackup/config.py", line 46, in __init__
    self._parser = self._setup_parser(filename)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/mackup/0.8.37/libexec/lib/python3.12/site-packages/mackup/config.py", line 150, in _setup_parser
    parser = configparser.SafeConfigParser(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
vincentkoc added a commit to vincentkoc/mackup that referenced this issue Oct 8, 2023
vincentkoc added a commit to vincentkoc/mackup that referenced this issue Oct 8, 2023
@MrZoidberg
Copy link

Is there a workaround?

@vincentkoc
Copy link
Contributor Author

@MrZoidberg already raised a PR #1949 and tested the changes locally and its working without issues in my current deployment

@lra lra closed this as completed in #1949 Nov 4, 2023
lra added a commit that referenced this issue Nov 4, 2023
* fix: Update config.py

#1948

* fix: Update appsdb.py

#1948

---------

Co-authored-by: Laurent Raufaste <[email protected]>
@castus
Copy link

castus commented Nov 4, 2023

Hi @lra , when do you plan to release this?

@lra
Copy link
Owner

lra commented Nov 4, 2023

@castus
Copy link

castus commented Nov 4, 2023

Thanks. Could you please update brew formula https://github.com/Homebrew/homebrew-core/blob/master/Formula/m/mackup.rb also?

@lra
Copy link
Owner

lra commented Nov 4, 2023

I don't maintain this, anyone can.
But you can already use pip or pipx to install the latest version.

@castus
Copy link

castus commented Nov 4, 2023

So what file do you maintain to have mackup up to date with brew?

@psarossy
Copy link

psarossy commented Nov 5, 2023

@castus The homebrew formula picks the updates up automatically (already on 0.8.39 there as well).

@lra
Copy link
Owner

lra commented Nov 5, 2023

Not automatically, someone did: Homebrew/homebrew-core#153351

@psarossy
Copy link

psarossy commented Nov 5, 2023

@lra apologies, you are correct, mackup indeed doesn't have github actions enabled after all; so the update is automated but someone has to trigger the PR manually...

@frederikkempe
Copy link

Thanks @lra! Works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants