Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated RawConfigParser (deprecated in python 3.12) #34

Closed
wants to merge 1 commit into from

Conversation

Thanhphan1147
Copy link

Hi,

I believe python 3.12 has removed SafeConfigParser.

This issue has been raised across multiple projects: here are a few examples:

I don't find any other references of SafeConfigParser in the repo, so I assume it'll be safe to remove it. Please let me know if that's not the case.

Here is the error when running pflake8 with python3.12

$ pflake8
Traceback (most recent call last):
  File "/home/ubuntu/flask-multipass-saml-groups/.tox/lint/bin/pflake8", line 5, in <module>
    from pflake8.__main__ import main
  File "/home/ubuntu/flask-multipass-saml-groups/.tox/lint/lib/python3.12/site-packages/pflake8/__init__.py", line 54, in <module>
    class DivertingSafeConfigParser(ConfigParserTomlMixin, configparser.SafeConfigParser):
                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

@Thanhphan1147
Copy link
Author

oops, just realized that there's already a PR for this.

@Thanhphan1147 Thanhphan1147 deleted the patch-2 branch April 5, 2024 16:10
@csachs
Copy link
Owner

csachs commented Apr 9, 2024

Thanks for the PR, fixed with #28 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants