Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a CPU/memory benchmark using iperf3 on localhost #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bp0
Copy link
Collaborator

@bp0 bp0 commented Jun 28, 2020

No description provided.

@mckaygerhard
Copy link
Contributor

this need:

  • a new runtime optional dependency: iperf3
  • option to command line to specify remote server (or input to gui?)

the test are agains localhost?

Copy link
Owner

@lpereira lpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit

static double _get_double(JsonParser *j, const char* path) {
double r = NAN;
GError *e = NULL;
JsonNode *root = json_parser_get_root(j);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building this should be conditional on finding the JSON library -- it's an optional dependency.

@@ -0,0 +1,123 @@
/*
* HardInfo - Displays System Information
* Copyright (C) 2003-2020 Leandro A. F. Pereira <[email protected]>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't write this file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants