computer/security: icons for CPU vulnerabilities [v3] #405
Conversation
|
The problem in using only colors is that this makes it harder for color-blind people to distinguish those icons. Using the |
|
Well, in this case the icons aren't by themselves. The text is right there next to it for the colorblind folks. |
|
Oh, I forgot to mention, there is a little demonstration in this PR where I used 128x128 sized icons and they work well. In the HTML view they will automatically get better with zoom or on HiDPI monitors, and since HardInfo is already using icon_cache_get_pixbuf_at_size() we could maybe adjust the size requested for that as well, based on the display. |
bp0
changed the title
bp0
force-pushed
the
vulnicons
branch
4 times, most recently
from
170bf19 to
8f9824f
Compare
bp0
changed the title
|
Now that the icons have shapes and are not color-only, do you still have an objection? |
|
Icons look better with distinctive shapes, but it would be nicer if they were using the same style as the rest of the icons. |
|
I've changed the green and red to match colors from existing icons. The green is from memory.png and the red is from dialog-error.png. They look pretty good with the others, in my opinion. I don't know that I have the talent to try and make new graphics that match the style of the old ones, so I'd ask that you just accept this PR and then replace the images with ones that you would prefer. I really think that going with SVG is a good idea as the old PNGs will look very bad on high resolution (FHD+) displays. I also think that there is value in having a generic set of "good", "ok/mixed", and "bad" icons like these. Here is a screen capture with the tweaked colors: |
|
hi guys.. great to see how are growing hardinfo.. .. i have friend blind person, testing in right way you must use orca.. currently i'm very busy but i noted we need a nithly build system.. of statically linked binaries for those test.. .. i dont remenber the GTK API but you @bp0 must take care that GTK2 and GTK3 can complaint/integrate with atspi api correctly (there's no so much rather than use the GTK right funtions.. that have support, like pass text inclusivelly if have a icon assigned) this it's not the only case @lpereira.. seems there's some code in old inherit that need some work too.. i'll try to compile a package and pass to my friend and report feedback |
Image Sources: https://www.flaticon.com/free-icon/warning_196760 https://www.flaticon.com/free-icon/cancel_189678 https://www.flaticon.com/free-icon/checked_189677 Image license: https://file000.flaticon.com/downloads/license/license.pdf Attribution required, may alter and create derivative works. Signed-off-by: Burt P <[email protected]>
Change colors to match previously existing icons. * Red is from dialog-error.png * Green is from memory.png Signed-off-by: Burt P <[email protected]>
Image Sources:
https://www.flaticon.com/free-icon/warning_196760
https://www.flaticon.com/free-icon/cancel_189678
https://www.flaticon.com/free-icon/checked_189677
Image license: https://file000.flaticon.com/downloads/license/license.pdf
Attribution required, may alter and create derivative works.
Looks like:
