Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed zone instance name #227

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

barryiron
Copy link

Fixes problem where the incorrect instance-name is set.

zone in my setup is set to crc and numZoneInstances to 2

Instance number 0 is always called default, however it should be called crc-inst0.

Before fix:

 loxicmd get lb -owide
|     EXT IP     | SEC IPS | SOURCES | HOST | PORT | PROTO |                   NAME                    | MARK | SEL |  MODE  |    ENDPOINT    | EPORT | WEIGHT | STATE | COUNTERS |
|----------------|---------|---------|------|------|-------|-------------------------------------------|------|-----|--------|----------------|-------|--------|-------|----------|
| 192.168.120.20 |         |         |      |  443 | tcp   | openshift-console_console-ext:default     |    0 | rr  | onearm | 192.168.126.11 | 31203 |      1 | -     | 0:0      |
| 192.168.120.21 |         |         |      |  443 | tcp   | openshift-console_console-ext-2:crc-inst1 |    0 | rr  | onearm | 192.168.126.11 | 30176 |      1 | -     | 0:0      |
| 192.168.120.22 |         |         |      |  443 | tcp   | openshift-console_console-ext-3:default   |    0 | rr  | onearm | 192.168.126.11 | 30901 |      1 | -     | 0:0      |
| 192.168.120.23 |         |         |      |  443 | tcp   | openshift-console_console-ext-4:crc-inst1 |    0 | rr  | onearm | 192.168.126.11 | 30559 |      1 | -     | 0:0      |

After fix:

loxicmd get lb -owide
|     EXT IP     | SEC IPS | SOURCES | HOST | PORT | PROTO |                   NAME                    | MARK | SEL |  MODE  |    ENDPOINT    | EPORT | WEIGHT | STATE | COUNTERS |
|----------------|---------|---------|------|------|-------|-------------------------------------------|------|-----|--------|----------------|-------|--------|-------|----------|
| 192.168.120.20 |         |         |      |  443 | tcp   | openshift-console_console-ext:crc-inst0   |    0 | rr  | onearm | 192.168.126.11 | 32196 |      1 | -     | 24:2619  |
| 192.168.120.21 |         |         |      |  443 | tcp   | openshift-console_console-ext-2:crc-inst1 |    0 | rr  | onearm | 192.168.126.11 | 31514 |      1 | -     | 0:0      |
| 192.168.120.22 |         |         |      |  443 | tcp   | openshift-console_console-ext-3:crc-inst0 |    0 | rr  | onearm | 192.168.126.11 | 30419 |      1 | -     | 24:2619  |
| 192.168.120.23 |         |         |      |  443 | tcp   | openshift-console_console-ext-4:crc-inst1 |    0 | rr  | onearm | 192.168.126.11 | 32609 |      1 | -     | 0:0      |

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@TrekkieCoder TrekkieCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. However, loxilb has some dependency on "default" instance name hence the reason for the check in the first place. But nonetheless, planning to take care of the these hard coded dependencies in loxilb.

@TrekkieCoder TrekkieCoder merged commit 1b9318d into loxilb-io:main Jan 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants