[python] Lint Python files with Ruff in CI (with ratchet) #26316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Wainwright <[email protected]>
I've tried to group these into units that are likely to be tacked as one when working on fixing lint problems. In some cases this means a single file, in others it's a directory or glob of directories. Signed-off-by: James Wainwright <[email protected]>
Currently every single Python file in the repository fails Ruff lints. Fix just one file so we can test the linter working. Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
ruff-ratchet
branch
2 times, most recently
from
bc333ca to
5b34efb
Compare
Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
jwnrt
requested review from
HU90m,
machshev and
a team
and removed request for
rswarbrick
rswarbrick
approved these changes
Feb 17, 2025
nbdd0121
reviewed
Feb 18, 2025
| @@ -85,6 +85,7 @@ dependencies = [ | |||
| # and bug fixes. We fix the version for improved stability and manually update | |||
| # if necessary. | |||
| "chipwhisperer@https://github.com/newaetech/chipwhisperer-minimal/archive/2643131b71e528791446ee1bab7359120288f4ab.zip", | |||
| "ruff>=0.9.6", | |||
There was a problem hiding this comment.
This is added to the wrong group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs Ruff in CI on all files which aren't excluded (which currently means one file).
Currently CI runs flake8 on files changed by a PR. This check is kept, Ruff runs as well.
Before this PR every single Python file fails Ruff's lints. This PR fixes one file as a proof of concept. The rest of the files are added to an exclude list and are not currently checked. The idea is that files will gradually be fixed and removed from this list, but not added (a ratchet).
I'd like to know if this is something that people want. Ruff seems like a pretty good linter and formatter that's easy to get a hold of and run.