Cherry-pick to earlgrey_1.0.0: [pentest] Add new OTBN FI tests #26281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This commit adds a test that can be used to target LW instruction on OTBN with FI. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit 0b58188)
This commit adds a test that allows a security evaluator to target the BN.SEL instruction of OTBN. Here, manipulating the carry flag could be one attack vector. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit 9a53fb4)
This commit adds the OTBN char.beq test. In this test, the FI target is the BEQ instruction - i.e., manipulating the jump Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit 3a111e2)
This test allows a security evaluator to characterize the big number instruction rshi. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit 1601b11)
Target the read WSR to register OTBN instruction with FI. The test returns the read registers back to the host. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit bcfed69)
This commit adds a test that can be used to check whether faults can manipulate data that is written into DMEM. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit dcdd169)
The goal of this test is to manipulate a program counter that is passed from Ibex to OTBN. When the PC is manipulated, the OTBN instruction counter does not match the expectation. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit d9f96a2)
The goal of this test is to fault to BNE instruction such that the jump is not performed. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]> (cherry picked from commit 10025ff)
For english breakfast targets, we are not waiting for the otbn to be finished. However, for the other targets, we should do this. Signed-off-by: Pascal Nasahl <[email protected]> (cherry picked from commit 0b13417)
github-actions
bot
requested review from
alees24
and removed request for
a team
nasahlpa
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #25589 to branch
earlgrey_1.0.0.