[python] add ruff linting support and exclude outdated flake8 rules #26264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbdd0121
reviewed
Feb 12, 2025
machshev
force-pushed
the
python_linting
branch
2 times, most recently
from
0cac5c4 to
c1ebf3d
Compare
nbdd0121
reviewed
Feb 12, 2025
Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
python_linting
branch
from
c1ebf3d to
60d8c6f
Compare
jwnrt
approved these changes
Feb 13, 2025
|
We can consider running Ruff in CI in the future, but I think it's basically fine to merge this config now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Ruff linting checks (https://github.com/astral-sh/ruff). This allows contributors to use ruff and ruff lsp and pass the CI linting checks.
The default Ruff config doesn't fully cover some of the flake8 rules we run in CI, so they need explicitly enabling. The only clash I can find at the moment is the flake8 rule W503 which is deprecated as it now goes against the current PEP8 recommendations (updated 2016). The flake8 config is therefore updated to disable the check.