Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools,topgen] Fix uniquification and simplify validate #26257

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[tools,topgen] Fix uniquification and simplify validate #26257

merged 2 commits into from
Feb 13, 2025

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Feb 12, 2025

This has two commits:

  • Fix problems in uniquification:
    • The feature was not triggered by any top so it was not tested
  • Minor simplification in the validate code:
    • Use dictionaries instead of arrays of ips, so avoids the need for
      indices

@matutem
[tools,topgen] Fix support for ipgen uniquification
cb78413 
Fix handling of uniquification in topgen.
Add module_instance_name parameter for alert_handler to enable
uniquification.
Add missing module_instance_name invocation in ac_range_check
hjson template.

Signed-off-by: Guillermo Maturana <[email protected]>
@matutem
[tools,topgen] Simplify xbar handling in validate pass
9856cac 
Pass dictionaries rather than arrays containing ip and xbar
information.

Signed-off-by: Guillermo Maturana <[email protected]>
rswarbrick
rswarbrick approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and rather cleaner!) to me.

@matutem matutem merged commit 1ba40eb into lowRISC:master Feb 13, 2025
42 checks passed
@matutem matutem deleted the topgen_uniquify branch February 13, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

@msfschaffner msfschaffner Awaiting requested review from msfschaffner msfschaffner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matutem @rswarbrick