[multitop] Refactor DIF and testutils #26252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They do not compile because those files were forgotten in the DIF unittest 'srcs' of the corresponding tests. Signed-off-by: Amaury Pouly <[email protected]>
pamaury
requested review from
jon-flatley,
a-will,
timothytrippel,
engdoreis,
AlexJones0,
jwnrt and
nbdd0121
and removed request for
a team
pamaury
force-pushed
the
multitop_testutils
branch
3 times, most recently
from
93f371f to
dde0263
Compare
jwnrt
approved these changes
Feb 12, 2025
|
Closes #25752 |
With the upcoming change to the isr_testutils, the DIF are no longer included as dependencies. The following two dependencies are affected and need to explicitely include more DIFs. Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
multitop_testutils
branch
from
dde0263 to
e127e1e
Compare
Virtually all DIFs use the same structure so instead of repeating the same thing many times over (and forget some files), use a loop to describe all DIFs. Signed-off-by: Amaury Pouly <[email protected]>
With this change, the tool becomes more flexible so it can be run by bazel. More precisely, we can select the output directory, we can also explicitely provide the path to the IP's Hjson files so that the tool doesn't have to guess. Signed-off-by: Amaury Pouly <[email protected]>
This rules runs util/autogen_testutils.py Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
Signed-off-by: Amaury Pouly <[email protected]>
Some dependencies depend on the top. For now manually select the right ones. Signed-off-by: Amaury Pouly <[email protected]>
The heartbeat mode modules the blink mode. This was fixed in: [dif,pwm] Heartbeat mode operates only when blinking enabled. but the unittest was not updated Signed-off-by: Amaury Pouly <[email protected]>
pamaury
force-pushed
the
multitop_testutils
branch
from
e127e1e to
e758c6a
Compare
a-will
approved these changes
Feb 12, 2025
jwnrt
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the DIF BUILD file and the autogen, it also refactor the testutils and switches them to a bazel rule.
On the technical side, an important change is that the
isr_tesutilsnow only depends on the autogen part of the DIF which means that it can be used even for IP which have no manual DIFs.NOTE: the testutils don't compile yet for Darjeeling due to a hardcoded dependency on earlgrey in the isr testutils structure. This will need to switch to DT and will be done in a follow-up PR.