[sw,multitop] port kmac_{app_rom,mode_cshake,mode_kmac}_test to devicetables #26243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
force-pushed
the
dt_kmac_tests
branch
from
e1e7944 to
0cc96f4
Compare
AlexJones0
requested review from
nbdd0121,
jwnrt and
pamaury
and removed request for
alees24
pamaury
reviewed
Feb 11, 2025
| ("//sw/device/silicon_creator/rom:mask_rom_fpga_cw310_hashfile", "fpga_cw310_sival"), | ||
| ("//sw/device/silicon_creator/rom:mask_rom_fpga_cw340_hashfile", "fpga_cw340_sival"), | ||
| ("//sw/device/lib/testing/test_rom:test_rom_sim_dv_hashfile", "sim_dv"), | ||
| ( |
There was a problem hiding this comment.
Comment for the future: we should find a way to make the execution environment provide the hashmap to avoid this manual list. This requires some bazel hacking, or it could just be done as part of the build system revamp for multitop that we are going to do.
There was a problem hiding this comment.
I'll add this as a TODO comment to the code I think as well
nbdd0121
approved these changes
Feb 11, 2025
AlexJones0
force-pushed
the
dt_kmac_tests
branch
2 times, most recently
from
0c81c89 to
2e56499
Compare
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
dt_kmac_tests
branch
from
2e56499 to
6ae214c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26216
Fix #26218
Fix #26219
Fix #26220
This PR ports 3 KMAC tests to use the devicetables API so that they no longer depend on Earlgrey-specific constants. All three tests remain passing on Earlgrey on FPGA (
fpga_cw310_rom_with_fake_keys), and will compile for Darjeeling using e.g.It might be worth updating
kmac_app_rom_testin the future so that each exec_env provides a way to get the hashfile of its ROM, so the information here is not hard-coded. But that is out of scope for this PR.Edit: I've also now tested chip_sw_kmac_mode_kmac_jitter_en is passing on Earlgrey via DVsim so I'm marking this as closing that issue as well.