[dv,cip] DV alert macro should work with size zero #26196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
requested review from
matutem
and removed request for
a team
rswarbrick
approved these changes
Feb 11, 2025
At the moment VCS complains that the size of the arrays in DV_ALERT_IF_CONNECT must not be zero or negative. To solve this I instantiate one of each when NUM_ALERTS is zero but the for loop that connects things up doesn't run. Signed-off-by: Marno van der Maas <[email protected]>
marnovandermaas
force-pushed
the
alert_zero_fix
branch
from
6652881 to
e54eff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment VCS complains that the size of the arrays in DV_ALERT_IF_CONNECT must not be zero or negative. To solve this I instantiate one of each when NUM_ALERTS is zero but the for loop that connects things up doesn't run.
Let me know if you know of a better solution. I tried a few options and this was the only one I could find that the tool found acceptable.