Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sival/hmac] Add Hmac Endian Test #26186

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[sival/hmac] Add Hmac Endian Test #26186

merged 1 commit into from
Feb 17, 2025

Conversation

nasahlpa
Copy link
Member

Add HMAC endian test as per chip_hmac_testplan.hjson Incorporated suggested changes from PR feedback

Signed-off-by: Ramesh Prakash [email protected]
(cherry picked from commit 4999941)

@rprakas-gsc @nasahlpa
[sival/hmac] Add Hmac Endian Test
ffe53ab 
Add HMAC endian test as per chip_hmac_testplan.hjson
Incorporated suggested changes from PR feedback

Signed-off-by: Ramesh Prakash <[email protected]>
(cherry picked from commit 4999941)
@nasahlpa nasahlpa mentioned this pull request Feb 10, 2025
Merged
@nasahlpa nasahlpa requested a review from rprakas-gsc February 10, 2025 09:34
@nasahlpa nasahlpa marked this pull request as ready for review February 10, 2025 11:35
@nasahlpa nasahlpa requested a review from a team as a code owner February 10, 2025 11:35
@nasahlpa nasahlpa requested review from jadephilipoom and engdoreis and removed request for a team and jadephilipoom February 10, 2025 11:35
rprakas-gsc
rprakas-gsc approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@rprakas-gsc rprakas-gsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jadephilipoom
jadephilipoom approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jadephilipoom jadephilipoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but leaves me wondering: does it make sense to test the key endianness (CFG.key_swap) here too, in combination with the other settings? Or is that covered by another test point?

@nasahlpa nasahlpa mentioned this pull request Feb 17, 2025
Open
@nasahlpa
Copy link
Member Author

Thanks @jadephilipoom for suggesting this. Yes, this would make sense. I've created an issue for this (#26321).

@nasahlpa nasahlpa merged commit 9d1dd9f into lowRISC:master Feb 17, 2025
40 checks passed
@nasahlpa nasahlpa deleted the hmac_endian_manual_cherry_pick branch February 17, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadephilipoom jadephilipoom jadephilipoom approved these changes

@rprakas-gsc rprakas-gsc rprakas-gsc approved these changes

@engdoreis engdoreis Awaiting requested review from engdoreis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nasahlpa @jadephilipoom @rprakas-gsc