Cherry-pick to earlgrey_1.0.0: [rom_ext,dice] Move dice_chain code from rom_ext to lib/cert #25069 #26185
+614
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 26127 introduced changes to the `dice_chain_attestation_owner` function when cherrypicking to master. It measures ownerblock in rom_ext instead of dice_chain library. This commit ports the changes back to earlgrey_1.0.0. Change-Id: I2ea49170c72b85c9a5ec545a40e9b693fd90518a Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit 6136439)
To share the dice code between (imm) rom_ext, those code in rom_ext.c are refactored and move to the lib/cert/dice_chain* as a common library. PR lowRISC#24980 has already refactored the code, and this PR moves them out from the rom_ext.c to the library folder. This PR only moves the code with necessary headers / dependencies rewrite. All functionalities are unchanged. Change-Id: I114fd31d72669c33e130e60868e1ee16500154d3 Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit f682e33)
This commit separates the interface out for the dice users to depend on. The actual implementation will be chosen by the rom_ext linking dependencies. Change-Id: Ibc218fa5b6ac0fc5314c1f5816995cb9ed957bb6 Signed-off-by: Yi-Hsuan Deng <[email protected]>
timothytrippel
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is manual cherry-pick from master, including
keymgron owner measurements #26127The first commit backport #26127 new function declaration from master to earlgrey_1.0.0.
The second commit applies #25069 to move the dice library.
The third commit is a new one that fixes the dice implementation dependency by separating the interface header.