[opentitantool] Several small fixes #26181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Feb 10, 2025
HyperDebug firmware has special code to pause during SPI or I2C TPM transactions, waiting for a pulse on a Google-specific "ready" signal. This change modifies the way the arguments must be passed to `spi.run_transaction()` to invoke that feature, such that they more closely match the sequence of events: Write, TpmPoll, Read, GscReady. Change-Id: Ia38e142c97f311c27367c916cbcda51af45ad500 Signed-off-by: Jes B. Klinke <[email protected]>
Change-Id: I7a304af363e05083a78213c1697e3eded4aa665f Signed-off-by: Jes B. Klinke <[email protected]>
If doing bitbanging and specifying a pause between segments of the waveform, the delay may not be an exact multiple of the base bitbanging sample frequency, as in this example: ``` opentitantool gpio bitbang --clock 115200Hz -s "0100001001 1ms 0100001001" CN9_6 ``` The code was intended to round off to a whole number of samples, as long as the actual time is within 1% of what was requested (115 sample times in the case above). However the original code had a bug meaning that it would accept only 99%-100% of the requested period, rather than 99%-101%. Change-Id: I79fd67926fedd7fb6dbae27d6314a28bc0b7f2e1 Signed-off-by: Jes B. Klinke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GscReadyfor I2C transactions, to more accurately reflect what HyperDebug does.