Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sram_ctrl,dv] Update coverage exclusions #25713

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions hw/ip/sram_ctrl/dv/cov/sram_ctrl_cov_excl.el
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,6 @@ Block 1 "461445014" "assign rsp_intg = tl_i.d_user.rsp_intg;"
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "2643129081" "assign data_intg = tl_i.d_user.data_intg;"

CHECKSUM: "281300783 1779845869"
INSTANCE: tb.dut.u_reg_regs.u_status_bus_integ_error.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"
INSTANCE: tb.dut.u_reg_regs.u_status_init_error.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"

CHECKSUM: "281300783 1779845869"
INSTANCE: tb.dut.u_reg_regs.u_status_escalated.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"

CHECKSUM: "1296247128 1854270750"
INSTANCE: tb.dut
ANNOTATION: "[UNSUPPORTED] ACK can't come without REQ"
Expand Down
56 changes: 56 additions & 0 deletions hw/ip/sram_ctrl/dv/cov/sram_ctrl_manual_cov_excl.el
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Copyright lowRISC contributors (OpenTitan project).
// Licensed under the Apache License, Version 2.0, see LICENSE for details.
// SPDX-License-Identifier: Apache-2.0

// The following exclusions were manually added.

// The reason for the following five exclusions are that "d" in "assign wr_data = d;"
// is driven by "hw2reg.status.<alert_name>.d = 1'b1' inside the "sram_ctrl" module.
CHECKSUM: "2099741489 2073313596"
INSTANCE: tb.dut.u_reg_regs.u_status_bus_integ_error.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"
INSTANCE: tb.dut.u_reg_regs.u_status_init_error.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"
CHECKSUM: "2099741489 2073313596"
INSTANCE: tb.dut.u_reg_regs.u_status_escalated.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"
CHECKSUM: "2099741489 2073313596"
INSTANCE: tb.dut.u_reg_regs.u_status_readback_error.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"
CHECKSUM: "2099741489 2073313596"
INSTANCE: tb.dut.u_reg_regs.u_status_sram_alert.wr_en_data_arb
ANNOTATION: "[UNR] all inputs are constant"
Block 2 "1620753216" "assign wr_data = d;"

// As the depth of this FIFO is 1, the following conditions cannot be met.
CHECKSUM: "3215070453 33318353"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte.gen_integ_handling.u_sync_fifo.gen_normal_fifo.u_fifo_cnt
Condition 1 "2532211833" "(incr_wptr_i & (wptr_o == 1'((Depth - 1)))) 1 -1"
Condition 7 "687544961" "(full_o ? (1'(Depth)) : ((wptr_wrap_msb == rptr_wrap_msb) ? ((1'(wptr_o) - 1'(rptr_o))) : (((1'(Depth) - 1'(rptr_o)) + 1'(wptr_o))))) 1 -1"
Condition 3 "2597027294" "(incr_rptr_i & (rptr_o == 1'((Depth - 1)))) 1 -1"
CHECKSUM: "3215070453 1827096802"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte.gen_integ_handling.u_sync_fifo.gen_normal_fifo.u_fifo_cnt
Branch 0 "721764659" "full_o" (0) "full_o 1,-"
Branch 0 "721764659" "full_o" (2) "full_o 0,0"
Branch 0 "721764659" "full_o" (1) "full_o 0,1"
CHECKSUM: "3215070453 3446030929"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte.gen_integ_handling.u_sync_fifo.gen_normal_fifo.u_fifo_cnt
Block 19 "4019242409" "wptr_wrap_cnt_q <= (wptr_wrap_cnt_q + {{(WrapPtrW - 1) {1'b0}}, 1'b1});"
Block 28 "1113085816" "rptr_wrap_cnt_q <= (rptr_wrap_cnt_q + {{(WrapPtrW - 1) {1'b0}}, 1'b1});"
CHECKSUM: "3215070453 1827096802"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte.gen_integ_handling.u_sync_fifo.gen_normal_fifo.u_fifo_cnt
Branch 1 "2417346495" "(!rst_ni)" (3) "(!rst_ni) 0,0,0,1"
Branch 2 "456961687" "(!rst_ni)" (3) "(!rst_ni) 0,0,0,1"

// Exclude the default branch of the FSM inside the tlul_sram_byte module as we
// should not reach it under normal conditions.
CHECKSUM: "432309571 1160560609"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte
Branch 1 "2309313685" "gen_integ_handling.state_q" (46) "gen_integ_handling.state_q default,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-,-"
CHECKSUM: "432309571 1673264206"
INSTANCE: tb.dut.u_tlul_adapter_sram.u_sram_byte
Block 86 "2943004802" "alert_o = 1'b1;"
4 changes: 2 additions & 2 deletions hw/ip/sram_ctrl/dv/cov/sram_ctrl_unr_excl.el
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ ANNOTATION: "VC_COV_UNR"
Block 12 "398307645" "wptr_o <= (wptr_o + {{(Width - 1) {1'b0}}, 1'b1});"
ANNOTATION: "VC_COV_UNR"
Block 21 "2517571270" "rptr_o <= (rptr_o + {{(Width - 1) {1'b0}}, 1'b1});"
CHECKSUM: "4263908928 1069164873"
CHECKSUM: "2326541723 4103140726"
INSTANCE: tb.dut.u_prim_ram_1p_scr
ANNOTATION: "VC_COV_UNR"
Block 23 "264295034" "rdata_o[k] = rdata[k];"
Block 28 "16825046" "rdata_o[k] = rdata[k];"
CHECKSUM: "4224194069 2881513198"
INSTANCE: tb.dut.u_tlul_lc_gate
ANNOTATION: "VC_COV_UNR"
Expand Down
1 change: 1 addition & 0 deletions hw/ip/sram_ctrl/dv/sram_ctrl_base_sim_cfg.hjson
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
reseed: 50

vcs_cov_excl_files: ["{proj_root}/hw/ip/sram_ctrl/dv/cov/sram_ctrl_cov_excl.el",
"{proj_root}/hw/ip/sram_ctrl/dv/cov/sram_ctrl_manual_cov_excl.el",
"{proj_root}/hw/ip/sram_ctrl/dv/cov/sram_ctrl_unr_excl.el"]

// Need to override the default output directory
Expand Down
Loading