Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[provisioning]: allow the owner to specify perso success condition #25406

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

vbendeb
Copy link

@vbendeb vbendeb commented Nov 26, 2024

Certain SKUs require personalization success validation which extends beyond confirming that the ROM_EXT in slot B has started.

Let's allow the user to specify a string which when issued on the chip console indicates perso success.

This will require longer timeouts after post perso reboot.

Tested the following:

  • when onwer string is not provided . success and failure due UDS cert problems are reported as before
  • when owner string is provided . failure due UDS cert problems is still reported . success when fw string is detected is reported . in case fw string is not detected timeout results in an error

@vbendeb vbendeb requested a review from a team as a code owner November 26, 2024 23:23
@vbendeb vbendeb requested review from timothytrippel and removed request for a team November 26, 2024 23:23
@vbendeb
Copy link
Author

vbendeb commented Nov 26, 2024

a suggested way to provision SKU specific perso success condition. Once agreed upon will modify SKUs to provide the expected anchor strings.

Copy link
Contributor

@timothytrippel timothytrippel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vbendeb !

Certain SKUs require personalization success validation which extends
beyond confirming that the ROM_EXT in slot B has started.

Let's allow the user to specify a string which when issued on the chip
console indicates perso success.

This will require longer timeouts after post perso reboot.

Tested the following:
  - when owner string is not provided
      . success and failure due to UDS cert problems are reported as
        before
  - when owner string is provided
    . failure due to UDS cert problems is still reported
    . success when fw string is detected is reported
    . in case fw string is not detected timeout results in an error

Signed-off-by: Vadim Bendebury <[email protected]>
@timothytrippel timothytrippel merged commit c865344 into lowRISC:earlgrey_1.0.0 Dec 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants