[bazel] Add OTP alert_handler digest generation #15890
Conversation
jon-flatley
force-pushed
the
otp_alert_bazel
branch
from
d76a5fa to
716c60e
Compare
|
Moving this out of draft stage. Just like #15872, this PR is also blocked on lowRISC/serde-annotate#10 to get hex serialization working in opentitantool. With that change the bazel rules added here seem to work as intended. |
jon-flatley
requested review from
cfrantz,
drewmacrae and
a team
as code owners
|
Moving this out of draft stage. Just like #15872, this PR is also blocked on lowRISC/serde-annotate#10 to get hex serialization working in opentitantool. With that change the bazel rules added here seem to work as intended. |
There was a problem hiding this comment.
Thanks @jon-flatley! (I reviewed only the last commit since the first three are included in the other PR).
jon-flatley
force-pushed
the
otp_alert_bazel
branch
4 times, most recently
from
d15734f to
daffcfe
Compare
Signed-off-by: Jon Flatley <[email protected]>
jon-flatley
force-pushed
the
otp_alert_bazel
branch
from
daffcfe to
4cac47a
Compare
| ), | ||
| "_opentitantool": attr.label( | ||
| default = "//sw/host/opentitantool:opentitantool", | ||
| allow_single_file = True, |
There was a problem hiding this comment.
I think this should have cfg = "exec" to avoid an implicit transition from the host platform to riscv32. https://bazel.build/rules/lib/attr#label
This PR builds on #14013.
This adds a rule,
otp_alert_digest, that creates an additional OTP image overlay containing theOWNER_SW_CFG_ROM_ALERT_DIGEST_<LC_STATE>values.Right now this is only done for RMA.
Leaving this as draft status as #14013 currently doesn't produce a JSON format that is accepted by the python tools. From what I can tell, this is because the python tools expect the items to be in the form of quoted hex values, and right now opentitantool is outputting these fields as regular JSON numbers in decimal.