Skip to content

Commit

Permalink
[cryptotest] Remove redundant SHAKE testvectors
Browse files Browse the repository at this point in the history
shake128_hardcoded.hjson
- Test cases 1-3 are already included in @nist_cavp_shake_fips_202
- Test case 4 already exists in a separate CSHAKE testvector hjson file

shake256_hardcoded.hjson
- Test cases 1 and 2 are already included in @nist_cavp_shake_fips_202
- Test case 3 already exists in a separate CSHAKE testvector hjson file

Signed-off-by: Miles Dai <[email protected]>
  • Loading branch information
milesdai committed Nov 15, 2024
1 parent c119b8c commit 6c87274
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 101 deletions.
4 changes: 0 additions & 4 deletions sw/device/tests/crypto/cryptotest/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,6 @@ SHAKE128_TESTVECTOR_TARGETS = [
"LongMsg",
"VariableOut",
]
] + [
"//sw/host/cryptotest/testvectors/data:hjson_shake128",
]

SHAKE128_TESTVECTOR_ARGS = " ".join([
Expand All @@ -261,8 +259,6 @@ SHAKE256_TESTVECTOR_TARGETS = [
"LongMsg",
"VariableOut",
]
] + [
"//sw/host/cryptotest/testvectors/data:hjson_shake256",
]

SHAKE256_TESTVECTOR_ARGS = " ".join([
Expand Down
2 changes: 0 additions & 2 deletions sw/device/tests/crypto/testvectors/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,4 @@ autogen_cryptotest_hjson_external(

exports_files([
"sha3_224_hardcoded.hjson",
"shake128_hardcoded.hjson",
"shake256_hardcoded.hjson",
])
39 changes: 0 additions & 39 deletions sw/device/tests/crypto/testvectors/shake128_hardcoded.hjson

This file was deleted.

32 changes: 0 additions & 32 deletions sw/device/tests/crypto/testvectors/shake256_hardcoded.hjson

This file was deleted.

24 changes: 0 additions & 24 deletions sw/host/cryptotest/testvectors/data/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -324,30 +324,6 @@ run_binary(
]
]

[
run_binary(
name = "hjson_{}".format(hash_alg),
srcs = [
"//sw/device/tests/crypto/testvectors:{}_hardcoded.hjson".format(hash_alg),
"//sw/host/cryptotest/testvectors/data/schemas:hash_schema.json",
],
outs = [":hjson_{}.json".format(hash_alg)],
args = [
"--src",
"$(location //sw/device/tests/crypto/testvectors:{}_hardcoded.hjson)".format(hash_alg),
"--dst",
"$(location :hjson_{}.json)".format(hash_alg),
"--schema",
"$(location //sw/host/cryptotest/testvectors/data/schemas:hash_schema.json)",
],
tool = "//sw/host/cryptotest/testvectors/parsers:hjson_hash_parser",
)
for hash_alg in [
"shake128",
"shake256",
]
]

[
run_binary(
name = cryptotest_name,
Expand Down

0 comments on commit 6c87274

Please sign in to comment.