[manifest] Add a Manager type for managing manifest updates
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Young de la Sota <[email protected]>
This type is analogous to a similar class of manager types in the Microsoft C implementation, whose primary purpose is to perform the necessary checks for activating a manifest. Right now, we expect the caller to track the "staging" area separately, though it may wind up making sense to move that into `Manager` in the fullness of time. Signed-off-by: Miguel Young de la Sota <[email protected]>
|
+jrvanwhy because there's some trait grossness here. |
jrvanwhy
reviewed
Apr 19, 2021
| /// | ||
| /// This function is the moral equivalent of `&mut []`; `OutOfMemory` | ||
| /// holds no data, so any non-null pointer is a suitable reference to | ||
| /// `OutOfMemory`. |
There was a problem hiding this comment.
This comment is technically incorrect (the pointer also needs to be aligned, and the alignment isn't guaranteed to be 1). It can probably be shortened to "This function is similar to &mut [], as OutOfMemory holds no data.".
alistair23
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is analogous to a similar class of manager types in the
Microsoft C implementation, whose primary purpose is to perform
the necessary checks for activating a manifest.
Right now, we expect the caller to track the "staging" area separately,
though it may wind up making sense to move that into
Managerin thefullness of time.