Cerberus tables tests #154
Conversation
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Miguel Young de la Sota <[email protected]>
Signed-off-by: Josiah Kiehl <[email protected]>
Signed-off-by: Josiah Kiehl <[email protected]>
Signed-off-by: Josiah Kiehl <[email protected]>
Signed-off-by: Josiah Kiehl <[email protected]>
Signed-off-by: Josiah Kiehl <[email protected]>
|
Go ahead and rebase when you get a chance (I'll review as-is anyways). |
| @@ -271,7 +283,7 @@ pub enum TypeKind<'md> { | |||
|
|
|||
| /// A row of a [`Table`] with values of type `Type`. | |||
| #[derive(Clone, Debug)] | |||
| pub struct TableRow<'md, Type> { | |||
| pub struct TableRow<'md, Type: std::fmt::Debug> { | |||
There was a problem hiding this comment.
Does this bound need to be here? I think it can be moved somewhere else.
| @@ -334,6 +346,12 @@ pub struct Error<'md> { | |||
| pub kind: ErrorKind, | |||
| } | |||
|
|
|||
| impl std::fmt::Display for Error<'_> { | |||
There was a problem hiding this comment.
Can you add a use for std::fmt and use just the fmt prefix?
| } | ||
|
|
||
| #[test] | ||
| fn markdownfile_parse_tables() { |
There was a problem hiding this comment.
Something I might recommend for when we add more tests is to do something like rustc's UI tests: https://github.com/rust-lang/rust/blob/master/src/test/ui/fn/fn-recover-return-sign2.rs#L5
The idea being that this makes it easier to find spans instead of having to hand-code them, which can be quite painful. You can pull in files via include_str!().
| @@ -135,7 +135,7 @@ impl<'md> Ident<'md> { | |||
| self.0 | |||
| } | |||
|
|
|||
| /// Returns the textual content of the wrapped Span. | |||
| /// Returns the textual content of the wrapped [`Span']. | |||
There was a problem hiding this comment.
Should be [`Span`]; note both are backticks. Rustdoc parses these automatically.
|
Also: could you rename your commits to all start with |
(depends on #150)
Add some simple tests for Markdown table parsing.