[manifest] Initial parser for the PCD #134
Conversation
| } | ||
|
|
||
| /// Returns total number of flash ports on this RoT. | ||
| pub fn flash_ports(&self) -> usize { |
There was a problem hiding this comment.
what is a flash_port? Is it a spi_flash interface or something else?
There was a problem hiding this comment.
No idea. I'm just taking a stab in the dark based off of the doc I read.
| } | ||
|
|
||
| /// Returns the total number of component RoTs connected to this RoT. | ||
| pub fn components(&self) -> usize { |
There was a problem hiding this comment.
Is a component an aggregation of endpoints connected via I2C and SPI?
There was a problem hiding this comment.
Presumably, but Cerberus doesn't currently define any endpoints connected over SPI. What I've implemented is basically what is written down today as a starting point.
| DualFiltered, | ||
| SingleFiltered, |
There was a problem hiding this comment.
I am not sure what DualFiltered and SingleFiltered map to. I assume it is a pluton's specific hardware feature.
There is also Quad support which may be available in some implementations.
There was a problem hiding this comment.
I have no idea either. I'm just blindly copying names for us to document later.
| /// This setting describes what to do with a port's reset line when the flash | ||
| /// is being verified with respect to a PFM. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| pub enum SpiResetPolicy { |
There was a problem hiding this comment.
I find this name a bit confusing because I read it as the SPI flash reset policy, whereas in reality it is the policy of the SPI host attached to the SPI flash device. Maybe SpiHostDeviceResetPolicy? Anyway, I think the docstring refers to it as a port. I wonder if this assumes that there is MUX or something between the host and the device...
There was a problem hiding this comment.
Not sure. My read was that this is what you're supposed to do to the flash device's reset line? This is my guess from like, three bullet points describing these policies, which are more-or-less copied down as the docstrings below.
Signed-off-by: Miguel Young de la Sota <[email protected]>
Note: this CL is layered on top of #133.
Unit tests and a
manifest::ownedimplementation still pending.