types: added missing types for OverlayOptions #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike-gg
changed the title
animated property for OverlayOptions
|
added also: |
lovell
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Thanks for the PR, great work finding these, the OverlayOptions definitions were inherited from the original DefinitelyTyped repo that we merged into sharp itself so these properties have always been missing.
Would it be possible for you to add a couple of tests for these properties to https://github.com/lovell/sharp/blob/main/test/types/sharp.test-d.ts ?
|
I have added type tests for these properties. please review and confirm if everything is okay |
lovell
approved these changes
Apr 2, 2024
|
Thank you very much for reporting and fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animatedproperty was missing from declaration types, just added it