chore: migrate to expo-sqlite

[lovegaoshi]

Summary by CodeRabbit

• New Features

  • Integrated SQLite support to enhance local data management.
  • Introduced an SQL migration option in Developer Settings, with automated migration during player setup.

• Refactor

  • Improved local storage handling for more reliable data operations.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2025 10:58pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request integrates SQLite support into the application. It adds the expo-sqlite plugin and dependency, introduces a new SQL migration function, and incorporates calls to this migration process from both the developer settings interface and the player setup hook. Additionally, the storage API functions have been updated to bind their context using the new SQLite-based key-value store. These modifications enhance data handling by migrating data from the previous AsyncStorage implementation to the new SQLite system.

Changes

File(s)	Change Summary
app.json, package.json	Added expo-sqlite support by including it as a plugin in app.json and a dependency (version ~15.1.2) in package.json.
src/components/setting/developer/DeveloperSettings.tsx, src/hooks/useSetupPlayer.ts	Imported and invoked the new sqlMigrate function. In DeveloperSettings, a new setting item labeled "SQLMigrate" is added to trigger migration; in useSetupPlayer, sqlMigrate() is called during player setup.
src/utils/ChromeStorageAPI.ts	Modified AsyncStorage usage by replacing the import with expo-sqlite/kv-store and updated function calls to bind AsyncStorage methods for proper context handling.
src/utils/sqlMigrate.ts	Introduced a new asynchronous function to migrate data: it checks for keys in the new storage, retrieves data from AsyncStorage if needed, writes the data using bound methods, and finally clears the old storage.

Sequence Diagram(s)

sequenceDiagram
    participant DS as DeveloperSettings/UI
    participant UP as useSetupPlayer
    participant SQL as sqlMigrate Function
    participant AS as AsyncStorage (old)
    participant KV as expo-sqlite/kv-store

    DS->>SQL: Trigger sqlMigrate(true)
    UP->>SQL: Call sqlMigrate() during player setup
    SQL->>KV: getAllKeysSync()
    alt Keys exist & not forced
        SQL-->>SQL: Exit migration
    else
        SQL->>AS: getAllKeys()
        SQL->>AS: multiGet(keys)
        SQL->>KV: multiSet(data) using bound methods
        SQL->>AS: clear()
    end

Loading

Possibly related PRs

• fix: asyncstorage race condition #753: Addresses modifications in AsyncStorage operations, aligning with the expo-sqlite and SQL migration changes implemented in this pull request.

Poem

I’m the rabbit that hops in code so free,
Migrating data with a delightful spree.
SQLite joins with secure grace,
Hopping through keys at a merry pace.
Cheers to new plugins, now watch me bound—
A joyful code garden, where fixes are found!
🐰✨

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2c3b29 and 11d1da0.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (6)

• app.json (1 hunks)
• package.json (1 hunks)
• src/components/setting/developer/DeveloperSettings.tsx (2 hunks)
• src/hooks/useSetupPlayer.ts (2 hunks)
• src/utils/ChromeStorageAPI.ts (6 hunks)
• src/utils/sqlMigrate.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud