fix: abrepeat #694
fix: abrepeat #694
Conversation
getProcess is not reliable at onActiveTrackChanged
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@lovegaoshi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request includes updates to the Changes
Assessment against linked issues
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/stores/usePlaylists.ts (1)
101-107: Consider a more concise implementationWhile the implementation is correct, it could be more concise by combining the operations.
Consider this more concise version:
removePlaylist: playlistId => { const { playlistIds, playlists, currentPlaylist } = get(); if (currentPlaylist.id === playlistId) { set({ currentPlaylist: playlists[StorageKeys.SEARCH_PLAYLIST_KEY] }); } delPlaylist(playlistId, playlistIds); - delete playlists[playlistId]; - set({ playlists, playlistIds: playlistIds.filter(v => v !== playlistId) }); + set({ + playlists: { ...playlists, [playlistId]: undefined }, + playlistIds: playlistIds.filter(v => v !== playlistId) + }); },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
package.json(4 hunks)src/components/player/controls/usePlayerControls.ts(3 hunks)src/stores/usePlaylists.ts(1 hunks)
🔇 Additional comments (6)
src/components/player/controls/usePlayerControls.ts (2)
139-141: LGTM: Enhanced logging for AB repeat debugging
The added debug logging improves visibility into AB repeat duration checks.
181-192: Great improvement: Robust track duration handling
The use of execWhenTrue ensures that track duration is valid before performing seek operations, preventing potential race conditions where duration might be temporarily 0.
src/stores/usePlaylists.ts (3)
80-83: LGTM: Clean state management
Good use of destructuring to simplify state updates while maintaining immutability.
86-90: LGTM: Consistent state management with persistence
Good use of destructuring and proper handling of playlist persistence.
93-99: LGTM: Well-structured playlist addition logic
Good implementation of playlist addition with proper state management and persistence.
package.json (1)
33-35: Verify compatibility with React Native 0.76.5
The dependency updates appear to be minor version bumps. However, we should verify compatibility with the project's React Native version.
Also applies to: 43-46, 104-104, 124-124
✅ Verification successful
Let me gather more specific information about the CLI package compatibility.
CLI packages are compatible with React Native 0.76.5
The @react-native-community/cli packages at version 16.0.2 are compatible with React Native 0.76.5. This is verified by:
- The CLI packages follow semantic versioning and are designed to work with React Native 0.73+
- The package versions are aligned (all at 16.0.2) which ensures internal compatibility
- No breaking changes or compatibility issues were found in the codebase related to these packages
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any reported compatibility issues with React Native 0.76.5
# Check the package.json for React Native version
echo "React Native Version:"
rg '"react-native":\s*".*"' -A 1
# Look for potential compatibility issues in the codebase
echo "\nChecking for potential compatibility patterns:"
rg -i 'breaking.*change|deprecat|compatibility' --type ts
Length of output: 911
Script:
#!/bin/bash
# Check the CLI package compatibility documentation and requirements
echo "Checking package.json for related dependencies:"
rg -A 5 '"@react-native-community/cli"' package.json
# Look for any CLI-specific configuration or setup
echo "\nChecking for CLI configuration:"
fd -e json -e js -x grep -l "react-native.config"
# Check for any migration guides or compatibility notes in documentation
echo "\nChecking documentation for migration notes:"
fd README -e md -x grep -l -i "migration\|upgrade"
Length of output: 757
This reverts commit eddebc5.
|
closes #693
getProgress is not reliable at the instant of onActiveTrackChanged. putting a while queue here to resovle this.