fix: local lyrics #229
Merged
fix: local lyrics #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh shit
delete RNfetchblob temps deleting lyric mapping can be done with a full reset.
hope the js size not equal issue is because of text ticker
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #227
lyrics are now written in appdir/documents/lyrics/*.txt;
if lyrics can be read, load;
if lyrics doesnt have .txt in it, show lyrics;
else, load search
we might need to refactor some Lyrics because the setStates wont work as expected as they will only be updated in the next refresh cycle. but hey it works. dont touch it then
also clean orphan cache will remove all unlisted RNTPBlob files.