New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] lyric view overhaul #227

Closed

lovegaoshi opened this issue Nov 7, 2023 · 2 comments · Fixed by #228 or #229

Assignees

Owner

lovegaoshi commented Nov 7, 2023

rework on styles so text in the lyric screen becomes more visible with dark themes;
save lyric into asyncstorage (?)
if user manually search/clicks a lyric, save it to asyncstorage
save lrc offset to asyncstorage
lrc is rendered every time on rn hot reload. worth fix for dev experience?

lovegaoshi self-assigned this

lovegaoshi mentioned this issue

feat: local lyric #228

Merged

lovegaoshi linked a pull request

that will close this issue

feat: local lyric #228

Merged

Owner Author

lovegaoshi commented Nov 7, 2023

存lrc进asyncstorage？没问题!
我运行像天堂

lovegaoshi closed this as completed in #228

Owner Author

lovegaoshi commented Nov 7, 2023

我运行向地狱
还是应该存进本地，uri存asyncstorage

lovegaoshi reopened this

lovegaoshi mentioned this issue

fix: local lyrics #229

Merged

lovegaoshi closed this as completed in #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment