Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add megasource support for SDL3 #17

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add megasource support for SDL3 #17

merged 2 commits into from
Apr 18, 2024

Conversation

learn-more
Copy link
Contributor

@learn-more learn-more commented Apr 17, 2024

This introduces a new CMake option LOVE_USE_SDL3 that defaults to OFF.
When this option is enabled, SDL3 variables will be set, and SDL2 variables will be cleared.

The PR is split up in 2 commits: one adding SDL 3.1.1-preview,
and one commit adding megasource specific stuff.

This PR is accompanied by love2d/love#2057

@slime73
Copy link
Member

slime73 commented Apr 18, 2024

Did SDL3's cmakelists.txt have to be modified at all, to get it to work with love?

@learn-more
Copy link
Contributor Author

Did SDL3's cmakelists.txt have to be modified at all, to get it to work with love?

This is an unmodified copy of SDL3.
If you prefer you or another developer could first import the unmodified SDL3 source, and I can rebase this PR on top of it.

@slime73
Copy link
Member

slime73 commented Apr 18, 2024

No need, I was just curious in case we'd need to reapply anything in future updates. Thanks!

@slime73 slime73 merged commit 3ead449 into love2d:main Apr 18, 2024
2 checks passed
@learn-more learn-more deleted the SDL3 branch April 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants