Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base changes #38

Merged
merged 5 commits into from
Apr 26, 2020
Merged

Base changes #38

merged 5 commits into from
Apr 26, 2020

Conversation

lovasoa
Copy link
Owner

@lovasoa lovasoa commented Apr 26, 2020

First PR to integrate @rdbeach work

See #31

@lovasoa
Copy link
Owner Author

lovasoa commented Apr 26, 2020

The switch to async was made on purpose to make the code more readable. You reverted it in
b35e020. Is there a reason in particular not to use async ?

@finnboeger
Copy link
Contributor

I had a look through the code again and don't see any particular necessity for the change. I believe we should be able to keep it as async/await.

@lovasoa lovasoa merged commit f23926b into lovasoa:master Apr 26, 2020
@lovasoa
Copy link
Owner Author

lovasoa commented Apr 26, 2020

Thank you !

@finnboeger finnboeger deleted the base-changes branch April 28, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants