Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and Add formatting to CI workflow #292

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Formatting and Add formatting to CI workflow #292

merged 4 commits into from
Nov 25, 2023

Conversation

bhavik001
Copy link
Contributor

Hello @lovasoa
I have added my work for the Issue #291
Can you please review my work and let me know if I have to add anything!

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting,
and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

Copy link
Owner

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me to merge when the tests pass !

@bhavik001
Copy link
Contributor Author

image

Hello,
I have resolve the error and all the test are running good once you approve it you can see. Please review and let me know if I have to make any changes.

@lovasoa lovasoa merged commit 38e8192 into lovasoa:master Nov 25, 2023
4 checks passed
@lovasoa
Copy link
Owner

lovasoa commented Nov 25, 2023

Thank you. Do you want to start working on linting ?

@bhavik001
Copy link
Contributor Author

I am starting it by tomorrow. Just to remind you can you assign me in the issue #291 . as I cannot assign myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants