Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Linting and Formatting feature #290

Closed
wants to merge 2 commits into from
Closed

Adding Linting and Formatting feature #290

wants to merge 2 commits into from

Conversation

bhavik001
Copy link
Contributor

@bhavik001 bhavik001 commented Nov 24, 2023

Issue #289

Adding ESLint and Prettier to this project repository.

  • Implemented the ESLint feature.
  • Implemented Prettier code formatter.
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

Copy link
Owner

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run the linting and formatting on CI ? (in .github/workfloaws/CI.yml)

@bhavik001
Copy link
Contributor Author

bhavik001 commented Nov 24, 2023

Hey @lovasoa
We can run formatting on ci but for linting we have so many linting error in the code. So, I just need your help in solving linting errors. I just need to be sure that the changes I am making is good or not!

@lovasoa
Copy link
Owner

lovasoa commented Nov 24, 2023

I don't think we should merge this if it returns linting errors. Maybe you should start with just formatting, and then activate linting rules one at a time, over several pull requests, making sure the CI is always green, to keep things manageable.

@bhavik001
Copy link
Contributor Author

Hello @lovasoa !
I just need to inform you that you can merge this branch. But add only formatter to the CI.yml file right now. I am working on fixing linitng errors. Is that okay! Please reply.

@bhavik001 bhavik001 closed this by deleting the head repository Nov 24, 2023
@lovasoa
Copy link
Owner

lovasoa commented Nov 24, 2023

Can you open a smaller pr with just formatting, and CI formatting ?

@bhavik001
Copy link
Contributor Author

Hey @lovasoa !
Can I just rename the issue to formatting and CI formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants