Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save user preferences #288

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

atomdmac
Copy link

Saves and restores various bits of application state:

  • Stroke size
  • Stroke opacity
  • Stroke color
  • Grid visibility and style
  • Selected tool

As part of this work, a reusable "Signals" facility has been added via createSignal. This allows multiple functions to subscribe to state changes.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

@lovasoa
Copy link
Owner

lovasoa commented Nov 20, 2023

Hey, thanks for the PR! I'm not sure what the use case for this is, though; and I don't think I'd like the brush parameters to be saved. If you have two windows opened, they will be constantly fighting for control over the saved parameters.

@atomdmac
Copy link
Author

I actually found it frustrating that I'd lost my settings between refreshes. What if the settings were saved per boars instead of globally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants