Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Download Svg Button #195

Merged
merged 15 commits into from
Jun 2, 2021
Merged

Conversation

DanielHabenicht
Copy link
Contributor

@DanielHabenicht DanielHabenicht commented May 27, 2021

Hi,

this PR addresses the requested changes on #122. Mainly:

  • does not make any changes to the svg area but rather clones it and then modifies it.
  • fixes the icon so if fits with the others
  • fixes reported styling issues
  • now uses the board name as filename

image

fixes #15

Hit me up if something else is missing or not working.

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

@DanielHabenicht
Copy link
Contributor Author

One more thing: Would you be interested in PNG Export as well (in another PR)?
I would need to add a package for that https://github.com/canvg/canvg

@sents
Copy link
Contributor

sents commented May 28, 2021

Actually just using all stylesheets in document.stylesheets doesn't work for some users. One users had a browser extension that adds stylesheets and trying to access them resulted in a cross origin policy exception. What I've come to do is to match on the href of the stylesheet and include matches of boad.css or boards/tools/*.css.

DanielHabenicht and others added 2 commits May 31, 2021 09:53
* use join
* don't use arrow functions
@DanielHabenicht
Copy link
Contributor Author

I've added your remarks and put in the stylesheet filtering mentioned by @sents

@DanielHabenicht
Copy link
Contributor Author

DanielHabenicht commented May 31, 2021

Also added support for IE download, but I think that was the last time I handled something extra for IE^ (Just so you know: https://death-to-ie11.com/)

Some other tools also don't support IE:

image

@DanielHabenicht
Copy link
Contributor Author

One more thing: Would you be interested in PNG Export as well (in another PR)?
I would need to add a package for that https://github.com/canvg/canvg

@lovasoa are you open to that?

@sents
Copy link
Contributor

sents commented May 31, 2021

Some other tools also don't support IE:

image

Ah yes, that was my selector pull request. I'm working to make it IE compatible.

@lovasoa
Copy link
Owner

lovasoa commented May 31, 2021

This looks great ! I'll try to merge later today !

@lovasoa lovasoa merged commit ab83c7f into lovasoa:master Jun 2, 2021
@lovasoa
Copy link
Owner

lovasoa commented Jun 2, 2021

It's merged and deployed. Thank you for this great contribution, @DanielHabenicht ! 🎉

@gigabyteservice
Copy link

@DanielHabenicht if I will merge this PR then this image download tool will create the problem ( download will works but if you will open that downloaded image then it will create the problem) , same thing is happening with this PR as well do you know how to solve this?

@DanielHabenicht
Copy link
Contributor Author

Can you describe the problem? (In your Issue and CC me)
I think the main problem ist the image embedding, not working seperatly (meaning only with SVG spec).

@DanielHabenicht DanielHabenicht deleted the download branch March 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to export to pdf/jpg/...
5 participants