-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Download Svg Button #195
Conversation
add board name for downloaded file
Co-authored-by: sents <[email protected]>
One more thing: Would you be interested in PNG Export as well (in another PR)? |
Actually just using all stylesheets in |
* use join * don't use arrow functions
Co-authored-by: sents <[email protected]>
I've added your remarks and put in the stylesheet filtering mentioned by @sents |
Also added support for IE download, but I think that was the last time I handled something extra for IE^ (Just so you know: https://death-to-ie11.com/) Some other tools also don't support IE: |
@lovasoa are you open to that? |
This looks great ! I'll try to merge later today ! |
It's merged and deployed. Thank you for this great contribution, @DanielHabenicht ! 🎉 |
@DanielHabenicht if I will merge this PR then this image download tool will create the problem ( download will works but if you will open that downloaded image then it will create the problem) , same thing is happening with this PR as well do you know how to solve this? |
Can you describe the problem? (In your Issue and CC me) |
Hi,
this PR addresses the requested changes on #122. Mainly:
svg
area but rather clones it and then modifies it.fixes #15
Hit me up if something else is missing or not working.
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.