Skip to content

Commit

Permalink
deps: V8: cherry-pick 97199f686e2f
Browse files Browse the repository at this point in the history
Original commit message:

    aix: add work around for f16 type

    AIX builds started to fail after this commit https://chromium.googlesource.com/v8/v8.git/+/d057564707d3a5df074b7f49a12a2f1e96638f94.

    Change-Id: I25a5c4ae3b4fe5c27a9fb9e35e2bcd2bbed40351
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789180
    Reviewed-by: Clemens Backes <[email protected]>
    Reviewed-by: Nico Hartmann <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#95952}

Refs: v8/v8@97199f6
PR-URL: nodejs#54536
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
targos authored and louwers committed Nov 2, 2024
1 parent ee784f6 commit 4815321
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.8',
'v8_embedder_string': '-node.9',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/src/utils/utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@

#if defined(V8_OS_AIX)
#include <fenv.h> // NOLINT(build/c++11)

#include "src/wasm/float16.h"
#endif

#ifdef _MSC_VER
Expand Down Expand Up @@ -814,6 +816,13 @@ T FpOpWorkaround(T input, T value) {
}
return value;
}

template <>
inline Float16 FpOpWorkaround(Float16 input, Float16 value) {
float result = FpOpWorkaround(input.ToFloat32(), value.ToFloat32());
return Float16::FromFloat32(result);
}

#endif

V8_EXPORT_PRIVATE bool PassesFilter(base::Vector<const char> name,
Expand Down

0 comments on commit 4815321

Please sign in to comment.