Disallow function declarations inside local scope

loumadev · Dec 3, 2023 · 3bd1664 · 3bd1664
1 parent 22cea54
commit 3bd1664
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/compiler/analyser/Analyser.c b/src/compiler/analyser/Analyser.c
@@ -902,6 +902,15 @@ AnalyserResult __Analyser_analyseBlock(Analyser *analyser, BlockASTNode *block)
 			case NODE_FUNCTION_DECLARATION: {
 				FunctionDeclarationASTNode *function = (FunctionDeclarationASTNode*)statement;
 
+				// Local scope function declarations are not supported
+				if(block->scope->parent) {
+					return AnalyserError(
+						RESULT_ERROR_SEMANTIC_OTHER,
+						String_fromFormat("function declarations are not allowed inside local scope"),
+						NULL
+					);
+				}
+
 				AnalyserResult result = __Analyser_analyseBlock(analyser, function->body);
 				if(!result.success) return result;
 

diff --git a/test/compiler/analyser/Analyser.test.c b/test/compiler/analyser/Analyser.test.c
@@ -1855,6 +1855,19 @@ DESCRIBE(function_dec_analysis, "Function declaration analysis") {
 			analyserResult = Analyser_analyse(&analyser, (ProgramASTNode*)parserResult.node);
 			EXPECT_FALSE(analyserResult.success);
 		}
+		{
+			Lexer_setSource(
+				&lexer,
+				"if(true) {" LF
+				TAB "func a() { }" LF
+				"}" LF
+			);
+			parserResult = Parser_parse(&parser);
+			EXPECT_TRUE(parserResult.success);
+
+			analyserResult = Analyser_analyse(&analyser, (ProgramASTNode*)parserResult.node);
+			EXPECT_FALSE(analyserResult.success);
+		}
 		{
 			Lexer_setSource(
 				&lexer,