Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display certificate Info (#1) #91

Merged
merged 15 commits into from
Jul 26, 2021
Merged

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Jul 21, 2021

Towards supporting #1

image

Got basic certificate info display working. The UI is very barebones, but should be functional.

Database migration now added. Front and back end now uses the URL() object as uniform access to helper methods.

Notification features are not implemented.

@louislam louislam added this to the 1.0.7 milestone Jul 21, 2021
@chakflying chakflying changed the title WIP: Display certificate Info WIP: Display certificate Info (#1) Jul 21, 2021
@louislam
Copy link
Owner

Great! I can improve the UI. And I am implementing the db migration.

@chakflying chakflying marked this pull request as ready for review July 22, 2021 08:05
@chakflying chakflying changed the title WIP: Display certificate Info (#1) Display certificate Info (#1) Jul 22, 2021
@louislam louislam added the feature-request Request for new features to be added label Jul 22, 2021
@louislam louislam linked an issue Jul 22, 2021 that may be closed by this pull request
@chakflying
Copy link
Collaborator Author

chakflying commented Jul 23, 2021

BTW I totally forgot an elephant in the room, should NODE_TLS_REJECT_UNAUTHORIZED = '0'; be set as default? In order for my code to obtain the status of self-signed certs, we have to set this so the request doesn't throw error. But this will have the side effect that websites with self-signed certs will now be shown as up, whereas they are shown as down currently.

@louislam
Copy link
Owner

But this will have the side effect that websites with self-signed certs will now be shown as up

Due to this reason, I would prefer to keep current setting.

@chakflying
Copy link
Collaborator Author

I guess an alternative would be to add a per-monitor setting to rejectUnauthorized to deal with self-signed, which statping has this.

# Conflicts:
#	server/model/monitor.js
@louislam louislam merged commit ac3732f into louislam:master Jul 26, 2021
@louislam
Copy link
Owner

louislam commented Jul 27, 2021

@chakflying arrr, your git commits did not bind to your GitHub account. Your name is not appearing in the "Contributors" section because of this sadly.

I guess an alternative would be to add a per-monitor setting to rejectUnauthorized to deal with self-signed, which statping has this.

This maybe a better solution. With a on/off button in the add/edit monitor page.

@chakflying chakflying deleted the tls-expiry branch October 18, 2021 11:01
@CommanderStorm CommanderStorm added area:status-page Everything related to the status page area:cert-expiry related to certificate expiry notifications labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cert-expiry related to certificate expiry notifications area:status-page Everything related to the status page feature-request Request for new features to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS Expiry alerts
5 participants