Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #1858
Implement server default appearances by injecting JSON data. If we use the established way of loading data after the front-end is initialized, there would be a flash of the default settings, which would not be a good user experience. Hence the method of preloading data for the status pages is also used to preload the server default settings into the HTML response.
Unfortunately this does not seem to play nice with the status page implementation, but there should be no reason for both middleware to exist at the same time. Hence the middleware is applied AFTER the status page routers are defined.
Type of change
Checklist
Screenshots (if any)