Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:addressing of simple deprecations surrounding Settings and log #4391

Closed
wants to merge 5 commits into from
Closed

chore:addressing of simple deprecations surrounding Settings and log #4391

wants to merge 5 commits into from

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Looking at our files, I found that two functions can be easily migrated:

  • functions that use settings now use the Settings-class
  • functions that use log now use the newer logging mechanism (usages of console.XYZ are folded to another PR)

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam louislam mentioned this pull request Jan 19, 2024
Closed
6 tasks
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 20, 2024
@CommanderStorm CommanderStorm changed the title adressing of simple deprecations chore:addressing of simple deprecations surrounding Settings and log Jan 20, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 23, 2024
@CommanderStorm CommanderStorm mentioned this pull request Sep 14, 2024
Open
1 task
fsteinke added a commit to fsteinke/uptime-kuma that referenced this pull request Sep 18, 2024
@fsteinke
feat(logging): integrate prs for louislam#4392 and louislam#4391
11f4fb0
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Sep 19, 2024
@SapphicCode
chore: addressing of simple deprecations surrounding Settings and `…
48d91cd 
…log`

Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4391

Squashed commit of the following:

commit 828d2a7
Merge: 10f771c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:51:25 2024 +0800

    Merge branch 'master' into deprecations

commit 10f771c
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:36:12 2024 +0100

    formatting fixes

commit d737b19
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:27:30 2024 +0100

    migrated all settings to use the `Settings` class

commit c5e26e9
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:04:44 2024 +0100

    removed the deprecated logging functionality
@SapphicCode SapphicCode mentioned this pull request Sep 19, 2024
Merged
7 tasks
CommanderStorm
CommanderStorm commented Sep 21, 2024
View reviewed changes
Copy link
Collaborator Author

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few linting fixes

@CommanderStorm
Copy link
Collaborator Author

Closing in favor of #5118

SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Oct 9, 2024
@SapphicCode
chore: addressing of simple deprecations surrounding Settings and `…
11e7916 
…log`

Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4391

Squashed commit of the following:

commit 828d2a7
Merge: 10f771c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:51:25 2024 +0800

    Merge branch 'master' into deprecations

commit 10f771c
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:36:12 2024 +0100

    formatting fixes

commit d737b19
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:27:30 2024 +0100

    migrated all settings to use the `Settings` class

commit c5e26e9
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:04:44 2024 +0100

    removed the deprecated logging functionality
@SapphicCode SapphicCode mentioned this pull request Oct 9, 2024
Open
7 tasks
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Oct 10, 2024
@SapphicCode
chore: addressing of simple deprecations surrounding Settings and `…
e85789e 
…log`

Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4391

Squashed commit of the following:

commit 828d2a7
Merge: 10f771c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:51:25 2024 +0800

    Merge branch 'master' into deprecations

commit 10f771c
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:36:12 2024 +0100

    formatting fixes

commit d737b19
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:27:30 2024 +0100

    migrated all settings to use the `Settings` class

commit c5e26e9
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 21:04:44 2024 +0100

    removed the deprecated logging functionality

* fix(server/model/monitor): duplicate `Settings.set` for `tlsExpiryNotifyDays`

* fix(eslint): minor linter complaints & a typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
house keeping pr:needs review this PR needs a review by maintainers or other community members pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderStorm @chakflying