Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Websocket Traffic by only sending CertInfo after login Events #4332

Closed
wants to merge 294 commits into from

Conversation

Neshura87
Copy link

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

While using the existing Socket API for an integration into a personal project I noticed that the Socket API generates an absolutely excessive amount of data mostly by resending the same certinfo over and over again. I'm not sure if this PR actually fixes that because I couldn't get the docker image to build on my machine so instead I'll use this draft PR to test it instead. More info once I determine this actually works.

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected) (TODO: figure out if this breaks anything)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

louislam and others added 30 commits September 1, 2023 05:19
louislam#3350)

* Added option to use `--intranet` to not download or update any files, this can only be done after an initial run.

* Dropped some unneeded debug changes that I commited by accident

* Added conventional suggestions from Github.com comments

---------

Co-authored-by: Jean-Paul van Houten - Bos <[email protected]>
…am#3263)

* WIP: Add msgTranslated to callbacks

* Chore: Unify Saved period

* Feat: add support for interpolation
* Don't run worst case test on GitHub Actions

* Deprecate jest
* Add toast timeout to the settings

Changing gui, adding timeout with a fix value

memo

rc

rollback readme

cleanup code

cleanup code

Review fixes

review fix 2

* Feat: Add clearAll button below toastContainer

* Feat: Load & Apply defaults, improve wording

Chore: Remove unused

* Feat: Change setting to affect monitor notif. only

* Apply suggestions from code review

Co-authored-by: Matthew Nickson <[email protected]>

* Chore: Fix JSDoc

---------

Co-authored-by: Berczi Sandor <[email protected]>
Co-authored-by: Matthew Nickson <[email protected]>
* fixed the lockfile having a different version

* jsdoc
* Adding x-www-form-urlencoded

* Adding example of x-www-form-urlencoding to body.

* A bit cleaner.

* Update server/model/monitor.js

Co-authored-by: Frank Elsinga <[email protected]>

* Update src/pages/EditMonitor.vue

Co-authored-by: Frank Elsinga <[email protected]>

* Update src/pages/EditMonitor.vue

Co-authored-by: Matthew Nickson <[email protected]>

* Add simple test

---------

Co-authored-by: Anders Kvist <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Louis Lam <[email protected]>
Co-authored-by: Matthew Nickson <[email protected]>
* extracted the dns monitor to its own monitor-type

* linting fixes

* another formatting fix

* Fix: Improve dnsMessage handling (louislam#3614)

* fixed docs

* fixed formatting changes
bjornclauw and others added 27 commits December 15, 2023 10:18
Currently translated at 100.0% (862 of 862 strings)

Co-authored-by: bjornclauw <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/nl/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 83.7% (722 of 862 strings)

Co-authored-by: abosaad11 <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/ar/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 83.1% (729 of 877 strings)

Co-authored-by: Alanimdeo <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/ko/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 100.0% (877 of 877 strings)

Co-authored-by: Marco <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/de_CH/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 86.5% (759 of 877 strings)

Translated using Weblate (Swedish)

Currently translated at 86.3% (757 of 877 strings)

Translated using Weblate (English)

Currently translated at 100.0% (877 of 877 strings)

Translated using Weblate (Swedish)

Currently translated at 49.0% (430 of 877 strings)

Co-authored-by: Gunnar Norin <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/en/
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/sv/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 99.4% (872 of 877 strings)

Co-authored-by: AmadeusGraves <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/es/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 99.8% (876 of 877 strings)

Co-authored-by: Abner Santana <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/pt_BR/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 50.6% (444 of 877 strings)

Co-authored-by: Rumplin <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/sl/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 100.0% (877 of 877 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (877 of 877 strings)

Co-authored-by: renph <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/zh_Hans/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 72.7% (638 of 877 strings)

Co-authored-by: Marco Beretta <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/it/
Translation: Uptime Kuma/Uptime Kuma
Currently translated at 100.0% (877 of 877 strings)

Co-authored-by: Vincent <[email protected]>
Translate-URL: https://weblate.kuma.pet/projects/uptime-kuma/uptime-kuma/nl/
Translation: Uptime Kuma/Uptime Kuma
# Conflicts:
#	package-lock.json
#	package.json
@Neshura87 Neshura87 changed the base branch from master to 1.23.X January 6, 2024 07:08
@Neshura87 Neshura87 closed this Jan 6, 2024
@Neshura87 Neshura87 deleted the master branch January 6, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.