-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Show monitor ID in Details #4331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing feature
I am not quite convinced the current design fits as is.
Have you experimented with these approaches? |
Personally, I don't like the "Tag that is not a Tag" design, and the font size had to be further reduced to fit in the same layout. Putting it next to the title looks fine, but because the title is variable length, the location would move around, which is not convenient for finding it, and we have to deal with overflow. Using |
Or you can implement copy ID button :) |
Have not tested it, but I think this can be disabled: https://dev.to/smpnjn/how-to-disable-text-selection-with-css-4jan |
Unfortunately does not work on Firefox Mobile, I guess it depends on browser/OS support. Using CSS to disable selection is a valid option I guess. |
I think I may prefer this, but with smaller font size. Because it does not require a new line when there are no tags. For highlight issue, I think |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #4274
Type of change
Checklist
Screenshots (if any)