Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Whapi notification provider #4323

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

edo2313
Copy link
Contributor

@edo2313 edo2313 commented Jan 4, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Added support for Whapi as a notification provider for WhatsApp. It has a generous free tier in the sandbox plan and is very simple to use. Potentially fixes #1816 as this doesn't require a business account. Also an alternative to #4316

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

CommanderStorm

This comment was marked as resolved.

@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Jan 5, 2024
@louislam louislam added this to the 2.1.0 milestone Jan 5, 2024
@edo2313
Copy link
Contributor Author

edo2313 commented Jan 8, 2024

Here are the screenshots.
I think I have reviewed all your changes, let me know if I missed something!

Setup
Test-Up-Down-CertificateExpired

@edo2313 edo2313 requested a review from CommanderStorm January 8, 2024 21:09
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

All changes meet the requirements from the contribution guide
⇒ merging with junior maintainer approval

(we have changed a few formatting things => fixing these)

@CommanderStorm CommanderStorm merged commit 822ce53 into louislam:master Apr 3, 2024
17 checks passed
@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Whatsapp] support notification provider
3 participants