Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected "Login" & "Logout" to verbs (EN) #4320

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

purplespider
Copy link
Contributor

  • I have read and understand the pull request rules.

Description

"Login" (one word) is a noun, not a verb, so the button text on the login form should really be "Log in" (two words). The same goes for "Logout" in the menu.

From what I can see, all current uses of the "Login" and "Logout" strings are used as verbs, so I have corrected the en.js file, changing them from nouns to verbs.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@CommanderStorm
Copy link
Collaborator

Please provide this input on weblate instead.
See our contribution guide: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#translations

We are strict with this rule as otherwise this causes merge conflicts between weblate and thus extra work for us wich is not managable

@chakflying
Copy link
Collaborator

I think this would be a special case as the e2e tests were broken after this change.

@louislam
Copy link
Owner

louislam commented Jan 4, 2024

Yes, maybe we should do this in this pr, because the e2e test is required to be updated.

@louislam louislam reopened this Jan 4, 2024
@louislam louislam added the question Further information is requested label Jan 4, 2024
@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Jan 5, 2024
@louislam louislam merged commit 8456912 into louislam:master Jan 13, 2024
17 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants