Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse heartbeat's msg in order to save disk space #3595

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

louislam
Copy link
Owner

@louislam louislam commented Aug 17, 2023

Resolves #3276

Noticed that some common messages are keep repeating and I believe the database will not compress them.

image

@louislam louislam changed the base branch from master to 2.0.X August 17, 2023 18:24
@CommanderStorm CommanderStorm mentioned this pull request Aug 18, 2023
2 tasks
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Oct 16, 2023
@CommanderStorm CommanderStorm deleted the branch master December 14, 2023 19:57
@chakflying
Copy link
Collaborator

Is this closed by mistake?

@CommanderStorm CommanderStorm deleted the improve-heartbeat-msg branch December 14, 2023 20:54
@CommanderStorm CommanderStorm restored the improve-heartbeat-msg branch December 14, 2023 21:30
@CommanderStorm
Copy link
Collaborator

Is this closed by mistake?

Sorry about the extra notifications and good catch for noticing this mistake.

I did delete all branches which had been merged earlier.
I likely should have been more careful in this 😅
This branch was closed as the 2.0.X branch has been merged into master earlier.

I am currently going through and fixing this

@louislam louislam deleted the branch master January 7, 2024 16:01
@louislam louislam closed this Jan 7, 2024
@louislam
Copy link
Owner Author

louislam commented Jan 7, 2024

Ops, I just fell into the same trap too. How did you reopen this?

@chakflying
Copy link
Collaborator

😂😂 Maybe you have to restore the branch first, then change the target branch to something else?

@CommanderStorm CommanderStorm reopened this Jan 7, 2024
@CommanderStorm
Copy link
Collaborator

😂😂 Maybe you have to restore the branch first, then change the target branch to something else?

I restored the branch.
Rebasing is something that I'd like to leave up to @louislam because maybe you have uncommitted changes/... (likely overparanoid, I know)

@CommanderStorm CommanderStorm changed the base branch from 2.0.X to master January 7, 2024 19:26
@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Apr 3, 2024
@CommanderStorm CommanderStorm added the pr:please address review comments this PR needs a bit more work to be mergable label May 19, 2024
@CommanderStorm CommanderStorm mentioned this pull request Oct 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI Hanging
3 participants