Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: make sql monitors eazier to use #3474

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3468 (comment)

  • makes the placeholder translatable
  • requires the query and connection string
    image
  • simplifying the code a bit (idk, why these templates were duplicated...)

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm CommanderStorm changed the title Fixed the sql monitor not having the query required Chore: make sql monitors eazier to use Jul 24, 2023
@chakflying
Copy link
Collaborator

Thinking about this, databaseConnectionString should also be required for monitor types redis and mongodb. Maybe we can merge those fields as well, and just add a v-if on the databaseQuery input, since that's not always needed.

@louislam louislam merged commit 149d08e into louislam:master Jul 31, 2023
@CommanderStorm CommanderStorm deleted the sql-mon-bugfix branch August 20, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSSQL Connection Error
4 participants