-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Both Add
and Home
being shown as selected on the homescreen
#3256
Merged
CommanderStorm
merged 8 commits into
louislam:master
from
CommanderStorm:unnested_router
Oct 4, 2024
Merged
fix: Both Add
and Home
being shown as selected on the homescreen
#3256
CommanderStorm
merged 8 commits into
louislam:master
from
CommanderStorm:unnested_router
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add
and Home
being shown as selected on the home-screenAdd
and Home
being shown as selected on the home-screenß
Add
and Home
being shown as selected on the home-screenßAdd
and Home
being shown as selected on the homescreen
a13f8c6
to
2a10749
Compare
310c429
to
28715e4
Compare
@louislam do you think reviewing this in |
Add
and Home
being shown as selected on the homescreenAdd
and Home
being shown as selected on the homescreen
I know this is merging my own PR, but I don't think there is more to review and the tradeoff is likely better than existing.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dashboard
The main dashboard page where monitors' status are shown
pr:needs review
this PR needs a review by maintainers or other community members
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Noticed by @devitq in #3244

Fixes
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.
/add
/edit/:monitorid
/clone/:monitorid