Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Both Add and Home being shown as selected on the homescreen #3256

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Jun 13, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Noticed by @devitq in #3244
Fixes
image

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

site previous now
/add image image
/edit/:monitorid image image
/clone/:monitorid image image

@CommanderStorm CommanderStorm changed the title Bug: Both Add and Home being shown as selected on the home-screen fix: Both Add and Home being shown as selected on the home-screenß Jun 13, 2023
@CommanderStorm CommanderStorm changed the title fix: Both Add and Home being shown as selected on the home-screenß Fix: Both Add and Home being shown as selected on the homescreen Jun 13, 2023
@CommanderStorm CommanderStorm marked this pull request as ready for review June 21, 2023 22:59
@louislam louislam added this to the 1.23.0 milestone Jun 25, 2023
@louislam louislam added the question Further information is requested label Jul 13, 2023
@louislam
Copy link
Owner

As I remembered, it is hard to handle both desktop and mobile. Vue router somehow is complicated and hard to test, I would not recommend making changes to it.

For example:
After this pr, [404] Fail won't be highlighted in the list anymore in the monitor list while entered the edit page.

image

@CommanderStorm CommanderStorm marked this pull request as draft July 13, 2023 16:40
@louislam louislam removed this from the 1.23.0 milestone Jul 14, 2023
@CommanderStorm CommanderStorm marked this pull request as ready for review July 25, 2023 17:16
@CommanderStorm
Copy link
Collaborator Author

CommanderStorm commented Jul 25, 2023

I have fixed the issue the change to the nesting of edit:id:
image

Current implementation:

  • it fixes Home+Add being shown for adding+cloning
  • keeps the edit-activation as is
  • But: removes the desktop-outline from
    image

Do you think this is a good tradeoff?

@CommanderStorm
Copy link
Collaborator Author

@louislam do you think reviewing this in 2.1/1.23.12 would be possible?
(a "no, removing the desktop outline from cloned monitors is not ok" and closing this PR would also be a fine choice..)

@CommanderStorm CommanderStorm removed the question Further information is requested label Mar 8, 2024
@CommanderStorm CommanderStorm added the area:dashboard The main dashboard page where monitors' status are shown label Apr 3, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@CommanderStorm CommanderStorm changed the title Fix: Both Add and Home being shown as selected on the homescreen fix: Both Add and Home being shown as selected on the homescreen Oct 4, 2024
@CommanderStorm
Copy link
Collaborator Author

I know this is merging my own PR, but I don't think there is more to review and the tradeoff is likely better than existing..

@CommanderStorm CommanderStorm merged commit da168fc into louislam:master Oct 4, 2024
17 checks passed
@CommanderStorm CommanderStorm deleted the unnested_router branch October 4, 2024 12:33
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants