Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for translation of messages from the server #2232

Closed

Conversation

karelkryda
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Currently, messages returned from the server are displayed in English. If the user chooses a different language, it would be useful to display the messages from the server in their chosen language as well.

This PR returns messages from the server as keys for i18n (instead of the default English texts), which are then translated.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • Translation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam
Copy link
Owner

louislam commented Oct 17, 2022

This PR returns messages from the server as keys for i18n (instead of the default English texts), which are then translated.

I thought this approach before too, but there are two things may have to be aware of.

  1. Some error messages could be dynamic.
  2. Uptime Kuma API could be possibly available in the future (Add foundation for API development #1834). As an API, if an error msg is a key that may not be helpful.

@louislam louislam mentioned this pull request Jan 3, 2023
6 tasks
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jun 30, 2023

@karelkryda
Could you close this PR in favor of #3263?
I think the approach is similar enough and mentioned PR is closer to be mergable

@karelkryda karelkryda closed this Jun 30, 2023
@CommanderStorm
Copy link
Collaborator

Thanks ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants