Implementing #928 with a cron expression. Limited code and workflow c… #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow changes.
Saibamen
reviewed
Feb 25, 2022
| const nextOccurences = later.schedule(laterCron).next(2); | ||
|
|
||
| let calculatedInterval = Math.floor((nextOccurences[0].getTime() - Date.now()) / 1000); | ||
| if (calculatedInterval < 20) { //beat interval too low, using next interval |
There was a problem hiding this comment.
Maybe in previous line (or next)?
Suggested change
| if (calculatedInterval < 20) { //beat interval too low, using next interval | |
| if (calculatedInterval < 20) { // beat interval too low, using next interval |
|
This feature is really cool to monitor cron tasks. Is there a schedule for the merge? Thanks ! |
|
Any explanation as to why this PR was closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #928 with a cron expression. Limited code and workflow changes.
Type of change
Checklist
Screenshots (if any)