Skip to content

Commit

Permalink
Chore: Use destructuring assignment to improve compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
chakflying committed Jan 24, 2024
1 parent a2c776f commit 88998e9
Showing 1 changed file with 15 additions and 6 deletions.
21 changes: 15 additions & 6 deletions server/uptime-calculator.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,11 @@ class UptimeCalculator {
dailyStatBean.ping = dailyData.avgPing;
dailyStatBean.pingMin = dailyData.minPing;
dailyStatBean.pingMax = dailyData.maxPing;
if (dailyData.maintenance) {
dailyStatBean.extras = JSON.stringify({ maintenance: dailyData.maintenance });
{
const { up, down, avgPing, minPing, maxPing, ...extras } = dailyData;

Check warning on line 294 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'up' is assigned a value but never used

Check warning on line 294 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'down' is assigned a value but never used

Check warning on line 294 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'avgPing' is assigned a value but never used

Check warning on line 294 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'minPing' is assigned a value but never used

Check warning on line 294 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'maxPing' is assigned a value but never used
if (Object.keys(extras).length > 0) {
dailyStatBean.extras = JSON.stringify(extras);
}
}
await R.store(dailyStatBean);

Expand All @@ -301,8 +304,11 @@ class UptimeCalculator {
hourlyStatBean.ping = hourlyData.avgPing;
hourlyStatBean.pingMin = hourlyData.minPing;
hourlyStatBean.pingMax = hourlyData.maxPing;
if (hourlyData.maintenance) {
hourlyStatBean.extras = JSON.stringify({ maintenance: hourlyData.maintenance });
{
const { up, down, avgPing, minPing, maxPing, ...extras } = hourlyData;

Check warning on line 308 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'up' is assigned a value but never used

Check warning on line 308 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'down' is assigned a value but never used

Check warning on line 308 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'avgPing' is assigned a value but never used

Check warning on line 308 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'minPing' is assigned a value but never used

Check warning on line 308 in server/uptime-calculator.js

View workflow job for this annotation

GitHub Actions / check-linters

'maxPing' is assigned a value but never used
if (Object.keys(extras).length > 0) {
hourlyStatBean.extras = JSON.stringify(extras);
}
}
await R.store(hourlyStatBean);

Expand All @@ -312,8 +318,11 @@ class UptimeCalculator {
minutelyStatBean.ping = minutelyData.avgPing;
minutelyStatBean.pingMin = minutelyData.minPing;
minutelyStatBean.pingMax = minutelyData.maxPing;
if (minutelyData.maintenance) {
minutelyStatBean.extras = JSON.stringify({ maintenance: minutelyData.maintenance });
{
const { up, down, avgPing, minPing, maxPing, ...extras } = minutelyData;
if (Object.keys(extras).length > 0) {
minutelyStatBean.extras = JSON.stringify(extras);
}
}
await R.store(minutelyStatBean);

Expand Down

0 comments on commit 88998e9

Please sign in to comment.