Skip to content

Commit

Permalink
Add a description to the new settings and move first heartbeat update
Browse files Browse the repository at this point in the history
  • Loading branch information
laupse committed Dec 20, 2023
1 parent 9ec2d2a commit 8366a37
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion src/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@
"Date Created": "Date Created",
"Footer Text": "Footer Text",
"Refresh Interval": "Refresh Interval",
"Refresh Interval Description": "The status page will do a full site refresh every {0} seconds",
"Show Powered By": "Show Powered By",
"Domain Names": "Domain Names",
"signedInDisp": "Signed in as {0}",
Expand Down Expand Up @@ -884,4 +885,4 @@
"deleteRemoteBrowserMessage": "Are you sure want to delete this Remote Browser for all monitors?",
"GrafanaOncallUrl": "Grafana Oncall URL",
"Browser Screenshot": "Browser Screenshot"
}
}
12 changes: 7 additions & 5 deletions src/pages/StatusPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@

<div class="my-3">
<label for="auto-refresh-interval" class="form-label">{{ $t("Refresh Interval") }}</label>
<input
id="auto-refresh-interval" v-model="config.autoRefreshInterval" type="number"
class="form-control" :min="5"
>
<input id="auto-refresh-interval" v-model="config.autoRefreshInterval" type="number"

Check warning on line 39 in src/pages/StatusPage.vue

View workflow job for this annotation

GitHub Actions / check-linters

Expected a linebreak before this attribute
class="form-control" :min="5">

Check failure on line 40 in src/pages/StatusPage.vue

View workflow job for this annotation

GitHub Actions / check-linters

Expected indentation of 27 spaces but found 24 spaces

Check warning on line 40 in src/pages/StatusPage.vue

View workflow job for this annotation

GitHub Actions / check-linters

Expected 1 line break before closing bracket, but no line breaks found
<div class="form-text">
{{ $t("Refresh Interval Description", [config.autoRefreshInterval]) }}
</div>
</div>

<div class="my-3">
Expand Down Expand Up @@ -717,7 +718,6 @@ export default {
this.loading = false;
// Configure auto-refresh loop
this.updateHeartbeatList();
feedInterval = setInterval(() => {
this.updateHeartbeatList();
}, (this.config.autoRefreshInterval + 10) * 1000);
Expand All @@ -730,6 +730,8 @@ export default {
console.log(error);
});
this.updateHeartbeatList();
// Go to edit page if ?edit present
// null means ?edit present, but no value
if (this.$route.query.edit || this.$route.query.edit === null) {
Expand Down

0 comments on commit 8366a37

Please sign in to comment.