make DOWN the default fallback for docker container healthcheck

louislam · Jan 15, 2024 · 54958c4 · 54958c4
1 parent 68c85f2
commit 54958c4
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/server/model/monitor.js b/server/model/monitor.js
@@ -747,15 +747,20 @@ class Monitor extends BeanModel {
                     let res = await axios.request(options);
 
                     if (res.data.State.Running) {
-                        if (res.data.State.Health && ![ "healthy", "unhealthy", "" ].includes(res.data.State.Health.Status)) {
-                            bean.status = PENDING;
-                            bean.msg = res.data.State.Health.Status;
-                        } else if (res.data.State.Health && res.data.State.Health.Status === "unhealthy") {
-                            bean.status = DOWN;
-                            bean.msg = res.data.State.Health.Status;
+                        if (res.data.State.Health) {
+                            if ([ "", "healthy" ].includes(res.data.State.Health.Status)) {
+                                bean.status = UP;
+                                bean.msg = res.data.State.Health.Status;
+                            } else if (res.data.State.Health.Status === "starting") {
+                                bean.status = PENDING;
+                                bean.msg = res.data.State.Health.Status;
+                            } else {
+                                bean.status = DOWN;
+                                bean.msg = res.data.State.Health.Status;
+                            }
                         } else {
-                            bean.status = UP;
-                            bean.msg = res.data.State.Health ? res.data.State.Health.Status : res.data.State.Status;
+                            bean.status = DOWN;
+                            bean.msg = res.data.State.Status;
                         }
                     } else {
                         throw Error("Container State is " + res.data.State.Status);